From: Eric Seppanen <eric@purestorage.com>
Date: Wed, 20 Nov 2013 22:19:51 +0000 (-0800)
Subject: iscsi-target: fix extract_param to handle buffer length corner case
X-Git-Tag: Ubuntu-snapdragon-4.4.0-1050.54~11297^2~1
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=369653e4fb511928511b0ce81f41c812ff1f28b6;p=mirror_ubuntu-artful-kernel.git

iscsi-target: fix extract_param to handle buffer length corner case

extract_param() is called with max_length set to the total size of the
output buffer.  It's not safe to allow a parameter length equal to the
buffer size as the terminating null would be written one byte past the
end of the output buffer.

Signed-off-by: Eric Seppanen <eric@purestorage.com>
Cc: <stable@vger.kernel.org> #3.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---

diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 21265c9c12b5..635751be5af7 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -88,7 +88,7 @@ int extract_param(
 	if (len < 0)
 		return -1;
 
-	if (len > max_length) {
+	if (len >= max_length) {
 		pr_err("Length of input: %d exceeds max_length:"
 			" %d\n", len, max_length);
 		return -1;