From: Miaoqian Lin Date: Wed, 16 Mar 2022 08:36:31 +0000 (+0000) Subject: ASoC: codecs: wcd934x: Add missing of_node_put() in wcd934x_codec_parse_data X-Git-Tag: Ubuntu-5.15.0-29.30~1258 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=3735be36671af20b3de45370bd3329b7f1ad5993;p=mirror_ubuntu-jammy-kernel.git ASoC: codecs: wcd934x: Add missing of_node_put() in wcd934x_codec_parse_data BugLink: https://bugs.launchpad.net/bugs/1969110 [ Upstream commit 9531a631379169d57756b2411178c6238655df88 ] The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. This is similar to commit 64b92de9603f ("ASoC: wcd9335: fix a leaked reference by adding missing of_node_put") Fixes: a61f3b4f476e ("ASoC: wcd934x: add support to wcd9340/wcd9341 codec") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220316083631.14103-1-linmq006@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin (cherry picked from commit 2f44eca78cc6d4e1779eb95765ec79e433accab4) Signed-off-by: Paolo Pisati --- diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 654d847a050e..7b99318070cf 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -5888,6 +5888,7 @@ static int wcd934x_codec_parse_data(struct wcd934x_codec *wcd) } wcd->sidev = of_slim_get_device(wcd->sdev->ctrl, ifc_dev_np); + of_node_put(ifc_dev_np); if (!wcd->sidev) { dev_err(dev, "Unable to get SLIM Interface device\n"); return -EINVAL;