From: Wolfram Sang Date: Sat, 14 Oct 2017 19:17:17 +0000 (+0200) Subject: mmc: omap_hsmmc: catch all errors when getting regulators X-Git-Tag: Ubuntu-5.10.0-12.13~9085^2~33 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=3b649a73692464cbd48eeb9785eeda9eaff5b5e5;p=mirror_ubuntu-hirsute-kernel.git mmc: omap_hsmmc: catch all errors when getting regulators Bail out everytime when mmc_regulator_get_supply() returns an errno, not only when probing gets deferred. This is currently a no-op, because this function only returns -EPROBE_DEFER or 0 right now. But if it will throw another error somewhen, it will be for a reason. (This still doesn't change that getting regulators is optional, so 0 can still mean no regulators found). So, let us a) be future proof and b) have driver code which is easier to understand. Signed-off-by: Wolfram Sang Signed-off-by: Ulf Hansson --- diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index f2a1137be8bc..071693ebfe18 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -445,7 +445,7 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) ret = mmc_regulator_get_supply(mmc); - if (ret == -EPROBE_DEFER) + if (ret) return ret; /* Allow an aux regulator */