From: Ido Schimmel <idosch@mellanox.com>
Date: Thu, 6 Aug 2015 14:41:57 +0000 (+0200)
Subject: mlxsw: Use correct skb length when dumping payload
X-Git-Tag: Ubuntu-snapdragon-4.4.0-1029.32~5986^2~207^2~1
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=3bfcd34764cbd3bcb48f6e9009eacf1d19856213;p=mirror_ubuntu-zesty-kernel.git

mlxsw: Use correct skb length when dumping payload

Do not use the length of the transmitted skb (which was freed), but
that of the response skb.

This issue was discovered using the Kernel Address sanitizer (KASan).

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
index 7562802bc6c8..09325b72d524 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -1073,7 +1073,7 @@ static int mlxsw_core_reg_access_emad(struct mlxsw_core *mlxsw_core,
 			mlxsw_core->emad.tid - 1);
 		mlxsw_core_buf_dump_dbg(mlxsw_core,
 					mlxsw_core->emad.resp_skb->data,
-					skb->len);
+					mlxsw_core->emad.resp_skb->len);
 
 		dev_kfree_skb(mlxsw_core->emad.resp_skb);
 	}