From: Daeseok Youn Date: Tue, 21 Mar 2017 02:12:57 +0000 (+0900) Subject: staging: atomisp: remove useless condition in if-statements X-Git-Tag: v4.13~799^2~402 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=435ec8afa59e28b4bcf2933da86b2c32fa326f8c;p=mirror_ubuntu-bionic-kernel.git staging: atomisp: remove useless condition in if-statements The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if- statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY', it could not enter the next if-statement. But the "next" if-statement has the condition to check whether the css_pipe_id equals to 'CSS_PIPE_ID_COPY' or not. It should be removed. Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c index 9d44a1dd220a..94bc7938f533 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c @@ -903,8 +903,7 @@ static struct atomisp_video_pipe *__atomisp_get_pipe( } else if (asd->run_mode->val == ATOMISP_RUN_MODE_VIDEO) { /* For online video or SDV video pipe. */ if (css_pipe_id == CSS_PIPE_ID_VIDEO || - css_pipe_id == CSS_PIPE_ID_COPY || - css_pipe_id == CSS_PIPE_ID_YUVPP) { + css_pipe_id == CSS_PIPE_ID_COPY) { if (buf_type == CSS_BUFFER_TYPE_OUTPUT_FRAME) return &asd->video_out_video_capture; return &asd->video_out_preview; @@ -912,8 +911,7 @@ static struct atomisp_video_pipe *__atomisp_get_pipe( } else if (asd->run_mode->val == ATOMISP_RUN_MODE_PREVIEW) { /* For online preview or ZSL preview pipe. */ if (css_pipe_id == CSS_PIPE_ID_PREVIEW || - css_pipe_id == CSS_PIPE_ID_COPY || - css_pipe_id == CSS_PIPE_ID_YUVPP) + css_pipe_id == CSS_PIPE_ID_COPY) return &asd->video_out_preview; } /* For capture pipe. */