From: Alexandre Courbot Date: Wed, 10 Dec 2014 19:07:20 +0000 (+0900) Subject: drm/nouveau: sgdma: add comment around suspiscious error handler X-Git-Tag: v4.13~5749^2~34^2~67 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=495b21761a4bf50c0453766ed8fdcfed075d43ff;p=mirror_ubuntu-bionic-kernel.git drm/nouveau: sgdma: add comment around suspiscious error handler Common programming sense dictates that resources allocated by a function are freed by this function should it fails, but this is not the case for the allocated structure of nouveau_sgdma_create_ttm(). It seems that n00b contributors attempt to fix this one like bugs flying towards a bug zapper, so add a comment to hopefully prevent this from happening anymore. Signed-off-by: Alexandre Courbot Signed-off-by: Ben Skeggs --- diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c index ec76c0b4e452..23c377a6c761 100644 --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c @@ -106,6 +106,11 @@ nouveau_sgdma_create_ttm(struct ttm_bo_device *bdev, nvbe->ttm.ttm.func = &nv50_sgdma_backend; if (ttm_dma_tt_init(&nvbe->ttm, bdev, size, page_flags, dummy_read_page)) + /* + * A failing ttm_dma_tt_init() will call ttm_tt_destroy() + * and thus our nouveau_sgdma_destroy() hook, so we don't need + * to free nvbe here. + */ return NULL; return &nvbe->ttm.ttm; }