From: Markus Elfring Date: Sun, 15 Nov 2015 21:42:27 +0000 (+0100) Subject: ACPI-EC: Drop unnecessary check made before calling acpi_ec_delete_query() X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~11201^2^3 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=4981c2b7abfe92a7ad3c9888b8a1ada552d49406;p=mirror_ubuntu-focal-kernel.git ACPI-EC: Drop unnecessary check made before calling acpi_ec_delete_query() The acpi_ec_delete_query() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring [ rjw: Subject ] Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index f61a7c834540..b420fb46669d 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -1103,7 +1103,7 @@ static int acpi_ec_query(struct acpi_ec *ec, u8 *data) } err_exit: - if (result && q) + if (result) acpi_ec_delete_query(q); if (data) *data = value;