From: Paolo Bonzini Date: Tue, 3 Apr 2012 08:05:07 +0000 (+0200) Subject: qdev: Clean up global properties X-Git-Tag: v1.2.0-rc0~267^2~9 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=4b3582b06b6105ac182a051e4f3647da2c99fd66;p=qemu.git qdev: Clean up global properties Now that global properties do not depend on buses anymore, set them directly in the device instance_init function. Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index b608eb443..390d467e8 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -440,7 +440,6 @@ DeviceState *qdev_device_add(QemuOpts *opts) /* create device, set properties */ qdev = DEVICE(object_new(driver)); qdev_set_parent_bus(qdev, bus); - qdev_prop_set_globals(qdev); id = qemu_opts_id(opts); if (id) { diff --git a/hw/qdev.c b/hw/qdev.c index f23990229..483f2e619 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -111,7 +111,6 @@ DeviceState *qdev_try_create(BusState *bus, const char *type) } qdev_set_parent_bus(dev, bus); - qdev_prop_set_globals(dev); return dev; } @@ -618,6 +617,7 @@ static void device_initfn(Object *obj) qdev_prop_set_defaults(dev, DEVICE_CLASS(class)->props); class = object_class_get_parent(class); } while (class != object_class_by_name(TYPE_DEVICE)); + qdev_prop_set_globals(dev); } /* Unlink device from bus and free the structure. */