From: Feifei Xu <Feifei.Xu@amd.com>
Date: Thu, 20 May 2021 09:46:03 +0000 (+0800)
Subject: drm/amd/pm: fix return value in aldebaran_set_mp1_state()
X-Git-Tag: Ubuntu-5.15.0-12.12~2367^2~16^2~97
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=5051cb794ac5d92154e186d87cdc12cba613f4f6;p=mirror_ubuntu-jammy-kernel.git

drm/amd/pm: fix return value in aldebaran_set_mp1_state()

For default cases,we should return 0. Otherwise resume will
abort because of the wrong return value.

Signed-off-by: Feifei Xu <Feifei.Xu@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
index fb744f3e17d7..d62cc6bb1a30 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
@@ -1856,10 +1856,8 @@ static int aldebaran_set_mp1_state(struct smu_context *smu,
 	case PP_MP1_STATE_UNLOAD:
 		return smu_cmn_set_mp1_state(smu, mp1_state);
 	default:
-		return -EINVAL;
+		return 0;
 	}
-
-	return 0;
 }
 
 static const struct pptable_funcs aldebaran_ppt_funcs = {