From: Michael Straube Date: Fri, 7 Jan 2022 10:36:04 +0000 (+0100) Subject: staging: r8188eu: release_firmware is not called if allocation fails X-Git-Tag: Ubuntu-5.15.0-36.37~1053 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=514439d28bd7a56544a480638463faaec40c32b0;p=mirror_ubuntu-jammy-kernel.git staging: r8188eu: release_firmware is not called if allocation fails BugLink: https://bugs.launchpad.net/bugs/1969110 [ Upstream commit 39850edf2befe27bcb3d6c37b6ee76d2ee4df903 ] In function load_firmware() release_firmware() is not called if the allocation of pFirmware->szFwBuffer fails or if fw->size is greater than FW_8188E_SIZE. Move the call to release_firmware() to the exit label at the end of the function to fix this. Fixes: 8cd574e6af54 ("staging: r8188eu: introduce new hal dir for RTL8188eu driver") Signed-off-by: Michael Straube Link: https://lore.kernel.org/r/20220107103620.15648-4-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin (cherry picked from commit 7a68abde36e1480fa4ad08a3229bb8d6a5355d47) Signed-off-by: Paolo Pisati --- diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c index a677b2049ef3..9f2b86f9b660 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -572,10 +572,10 @@ static int load_firmware(struct rt_firmware *pFirmware, struct device *device) } memcpy(pFirmware->szFwBuffer, fw->data, fw->size); pFirmware->ulFwLength = fw->size; - release_firmware(fw); dev_dbg(device, "!bUsedWoWLANFw, FmrmwareLen:%d+\n", pFirmware->ulFwLength); Exit: + release_firmware(fw); return rtStatus; }