From: Markus Armbruster Date: Fri, 7 Jun 2013 13:00:35 +0000 (+0200) Subject: smbios: Fix -smbios type=0, release=... for big endian hosts X-Git-Tag: v1.6.0-rc0~227 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=527cd96f15348f4454d5bb71f69aaeb95461c90e;p=qemu.git smbios: Fix -smbios type=0, release=... for big endian hosts Classic endianness bug due to careless dirty coding: assuming reading a byte from an int variable gets the least significant byte. Signed-off-by: Markus Armbruster Reviewed-by: Laszlo "ever the optimist" Ersek Message-id: 1370610036-10577-6-git-send-email-armbru@redhat.com Signed-off-by: Anthony Liguori --- diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index 322f0a0d6..6431dd4d8 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@ -127,6 +127,7 @@ void smbios_add_field(int type, int offset, const void *data, size_t len) static void smbios_build_type_0_fields(const char *t) { char buf[1024]; + unsigned char major, minor; if (get_param_value(buf, sizeof(buf), "vendor", t)) smbios_add_field(0, offsetof(struct smbios_type_0, vendor_str), @@ -139,8 +140,7 @@ static void smbios_build_type_0_fields(const char *t) bios_release_date_str), buf, strlen(buf) + 1); if (get_param_value(buf, sizeof(buf), "release", t)) { - int major, minor; - sscanf(buf, "%d.%d", &major, &minor); + sscanf(buf, "%hhu.%hhu", &major, &minor); smbios_add_field(0, offsetof(struct smbios_type_0, system_bios_major_release), &major, 1);