From: Gustavo A. R. Silva <garsilva@embeddedor.com>
Date: Tue, 2 Jan 2018 14:02:06 +0000 (-0600)
Subject: USB: usbip: remove useless call in usbip_recv
X-Git-Tag: Ubuntu-5.10.0-12.13~8524^2~50
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=55448d85ae2f7f2b6c43d66946146ec89b4eb088;p=mirror_ubuntu-hirsute-kernel.git

USB: usbip: remove useless call in usbip_recv

Calling msg_data_left(&msg) is only useful for its return value,
which in this particular case is ignored.

Fix this by removing such call.

Addresses-Coverity-ID: 1427080
Fixes: 90120d15f4c3 ("usbip: prevent leaking socket pointer address in messages")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
index 7b219d9109b4..b5af6fc7169b 100644
--- a/drivers/usb/usbip/usbip_common.c
+++ b/drivers/usb/usbip/usbip_common.c
@@ -325,7 +325,6 @@ int usbip_recv(struct socket *sock, void *buf, int size)
 	usbip_dbg_xmit("enter\n");
 
 	do {
-		msg_data_left(&msg);
 		sock->sk->sk_allocation = GFP_NOIO;
 
 		result = sock_recvmsg(sock, &msg, MSG_WAITALL);