From: Tang Bin Date: Fri, 3 Apr 2020 22:07:54 +0000 (+0800) Subject: crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe() X-Git-Tag: Ubuntu-5.10.0-12.13~2805^2~102 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=56e0b6273ec8791ffe1c3cdc5d32fe5d001fd520;p=mirror_ubuntu-hirsute-kernel.git crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe() When something goes wrong, platform_get_irq() will print an error message, so in order to avoid the situation of repeat output，we should remove dev_err here. Signed-off-by: Tang Bin Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c index 9d4ead2f7ebb..411857fad8ba 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-core.c +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c @@ -253,10 +253,8 @@ static int meson_crypto_probe(struct platform_device *pdev) mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL); for (i = 0; i < MAXFLOW; i++) { mc->irqs[i] = platform_get_irq(pdev, i); - if (mc->irqs[i] < 0) { - dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i); + if (mc->irqs[i] < 0) return mc->irqs[i]; - } err = devm_request_irq(&pdev->dev, mc->irqs[i], meson_irq_handler, 0, "gxl-crypto", mc);