From: Ville Syrjälä Date: Fri, 18 Nov 2016 19:52:58 +0000 (+0200) Subject: drm: Reject fbs w/o format info in drm_framebuffer_init() X-Git-Tag: Ubuntu-4.11.0-0.5~545^2~48^2~85 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=570cec3244447f21f5b24c3a75151b4166e30d95;p=mirror_ubuntu-artful-kernel.git drm: Reject fbs w/o format info in drm_framebuffer_init() Any framebuffer that doesn't have proper format information when drm_framebuffer_init() is called is a bug. Let's warn and return an error to avoid oopsing the kernel later due to dereferencing the NULL fb->format pointer. Cc: Laurent Pinchart Suggested-by: Laurent Pinchart Signed-off-by: Ville Syrjälä Link: http://patchwork.freedesktop.org/patch/msgid/1479498793-31021-23-git-send-email-ville.syrjala@linux.intel.com Reviewed-by: Laurent Pinchart --- diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index f397565d3c20..892976d974e5 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -631,7 +631,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb, { int ret; - if (WARN_ON_ONCE(fb->dev != dev)) + if (WARN_ON_ONCE(fb->dev != dev || !fb->format)) return -EINVAL; INIT_LIST_HEAD(&fb->filp_head);