From: Juergen Gross Date: Mon, 31 Oct 2016 13:58:41 +0000 (+0100) Subject: xen: make use of xenbus_read_unsigned() in xen-pcifront X-Git-Tag: Ubuntu-5.10.0-12.13~11305^2~21 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=58faf07b76817782ea20c392639569ea613cd439;p=mirror_ubuntu-hirsute-kernel.git xen: make use of xenbus_read_unsigned() in xen-pcifront Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. This requires to change the type of the read from int to unsigned, but this case has been wrong before: negative values are not allowed for the modified case. Cc: bhelgaas@google.com Cc: linux-pci@vger.kernel.org Signed-off-by: Juergen Gross Acked-by: Bjorn Helgaas Acked-by: David Vrabel --- diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index d6ff5e82377d..8fc2e9532575 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -1038,10 +1038,8 @@ static int pcifront_detach_devices(struct pcifront_device *pdev) err = -ENOMEM; goto out; } - err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str, "%d", - &state); - if (err != 1) - state = XenbusStateUnknown; + state = xenbus_read_unsigned(pdev->xdev->otherend, str, + XenbusStateUnknown); if (state != XenbusStateClosing) continue;