From: Dominik Csapak <d.csapak@proxmox.com>
Date: Mon, 30 May 2016 08:44:37 +0000 (+0200)
Subject: do not ignore hotplug parse errors
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=596a0a20567d239b1abcefedb55947a32b28bae3;p=qemu-server.git

do not ignore hotplug parse errors

if we got an option which was not valid, we still
wrote it to the config, and subsequently returned
it on every api call

instead, now we die instead of warn and do not accept
invalid options

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5813242..2da9208 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -1232,7 +1232,7 @@ sub parse_hotplug_features {
 	if ($feature =~ m/^(network|disk|cpu|memory|usb)$/) {
 	    $res->{$1} = 1;
 	} else {
-	    warn "ignoring unknown hotplug feature '$feature'\n";
+	    die "invalid hotplug feature '$feature'\n";
 	}
     }
     return $res;