From: Jing Xiangfeng <jingxiangfeng@huawei.com>
Date: Fri, 25 Sep 2020 06:24:23 +0000 (+0800)
Subject: scsi: bfa: Fix error return in bfad_pci_init()
X-Git-Tag: Ubuntu-5.4.0-55.61~145
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=5ac8179f03aa1649c1da41a68ba2c41bfebbc85e;p=mirror_ubuntu-focal-kernel.git

scsi: bfa: Fix error return in bfad_pci_init()

BugLink: https://bugs.launchpad.net/bugs/1902115

[ Upstream commit f0f6c3a4fcb80fcbcce4ff6739996dd98c228afd ]

Fix to return error code -ENODEV from the error handling case instead of 0.

Link: https://lore.kernel.org/r/20200925062423.161504-1-jingxiangfeng@huawei.com
Fixes: 11ea3824140c ("scsi: bfa: fix calls to dma_set_mask_and_coherent()")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Ian May <ian.may@canonical.com>
---

diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c
index 2f9213b257a4..93e401180991 100644
--- a/drivers/scsi/bfa/bfad.c
+++ b/drivers/scsi/bfa/bfad.c
@@ -749,6 +749,7 @@ bfad_pci_init(struct pci_dev *pdev, struct bfad_s *bfad)
 
 	if (bfad->pci_bar0_kva == NULL) {
 		printk(KERN_ERR "Fail to map bar0\n");
+		rc = -ENODEV;
 		goto out_release_region;
 	}