From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 28 Oct 2013 11:54:52 +0000 (+0100)
Subject: ALSA: Optimize module name check
X-Git-Tag: Ubuntu-snapdragon-4.4.0-1029.32~9836^2~62
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=60f6fef877d52525b8887d27cfacf74a279e3e12;p=mirror_ubuntu-zesty-kernel.git

ALSA: Optimize module name check

module->name is a fixed array, so we can check the empty contents
straightforwardly in module_slot_match().

Spotted by coverity CID 1056786.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/core/init.c b/sound/core/init.c
index 6b9087115da2..01a89383a062 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -66,7 +66,7 @@ static int module_slot_match(struct module *module, int idx)
 #ifdef MODULE
 	const char *s1, *s2;
 
-	if (!module || !module->name || !slots[idx])
+	if (!module || !*module->name || !slots[idx])
 		return 0;
 
 	s1 = module->name;