From: Maninder Singh Date: Wed, 8 Jul 2015 06:56:47 +0000 (+0530) Subject: rtc: bq32k: remove redundant check X-Git-Tag: Ubuntu-5.10.0-12.13~14127^2~84 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=617f6f7ef5bfe8c0ac580243c3da9a836c6e39bf;p=mirror_ubuntu-hirsute-kernel.git rtc: bq32k: remove redundant check removing below static analysis error: (error) Possible null pointer dereference: client if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) ^^^^^^^ Error comes because client is dereferenced before NULL check. So probably NULL this check is not required. Signed-off-by: Maninder Singh Signed-off-by: Alexandre Belloni --- diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c index 92679df6d6e2..409de9f1b604 100644 --- a/drivers/rtc/rtc-bq32k.c +++ b/drivers/rtc/rtc-bq32k.c @@ -212,7 +212,7 @@ static int bq32k_probe(struct i2c_client *client, if (error) return error; - if (client && client->dev.of_node) + if (client->dev.of_node) trickle_charger_of_init(dev, client->dev.of_node); rtc = devm_rtc_device_register(&client->dev, bq32k_driver.driver.name,