From: Zhang Chen Date: Tue, 5 Sep 2017 06:31:05 +0000 (+0800) Subject: net/colo-compare.c: Adjust net queue pop order for performance X-Git-Tag: v2.11.1~262^2~4 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=626bba988af8f38b2820f60cfdf5a27bcb74123b;p=mirror_qemu.git net/colo-compare.c: Adjust net queue pop order for performance The packet_enqueue() use g_queue_push_tail() to enqueue net packet, so it is more efficent way use g_queue_pop_head() to get packet for compare. That will improve the success rate of comparison. In my test the performance of ftp put 1000M file will increase 10% Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- diff --git a/net/colo-compare.c b/net/colo-compare.c index 612fbac72c..f480315753 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -484,7 +484,7 @@ static void colo_compare_connection(void *opaque, void *user_data) while (!g_queue_is_empty(&conn->primary_list) && !g_queue_is_empty(&conn->secondary_list)) { - pkt = g_queue_pop_tail(&conn->primary_list); + pkt = g_queue_pop_head(&conn->primary_list); switch (conn->ip_proto) { case IPPROTO_TCP: result = g_queue_find_custom(&conn->secondary_list, @@ -522,7 +522,7 @@ static void colo_compare_connection(void *opaque, void *user_data) * until next comparison. */ trace_colo_compare_main("packet different"); - g_queue_push_tail(&conn->primary_list, pkt); + g_queue_push_head(&conn->primary_list, pkt); /* TODO: colo_notify_checkpoint();*/ break; }