From: Wei Yongjun Date: Wed, 12 Apr 2017 00:31:16 +0000 (+0000) Subject: drm/etnaviv: fix missing unlock on error in etnaviv_gpu_submit() X-Git-Tag: Ubuntu-4.10.0-22.24~211 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=62dd80f54582f8e16deca73de49ac62db8d8ad8d;p=mirror_ubuntu-zesty-kernel.git drm/etnaviv: fix missing unlock on error in etnaviv_gpu_submit() BugLink: http://bugs.launchpad.net/bugs/1687045 commit 45abdf35cf82e4270328c7237e7812de960ac560 upstream. Add the missing unlock before return from function etnaviv_gpu_submit() in the error handling case. lst: fixed label name. Fixes: f3cd1b064f11 ("drm/etnaviv: (re-)protect fence allocation with GPU mutex") Signed-off-by: Wei Yongjun Signed-off-by: Lucas Stach Signed-off-by: Greg Kroah-Hartman Signed-off-by: Stefan Bader Signed-off-by: Thadeu Lima de Souza Cascardo --- diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index db0a43a090d0..34ffe6e1f6d0 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c @@ -1309,7 +1309,7 @@ int etnaviv_gpu_submit(struct etnaviv_gpu *gpu, if (!fence) { event_free(gpu, event); ret = -ENOMEM; - goto out_pm_put; + goto out_unlock; } gpu->event[event].fence = fence; @@ -1349,6 +1349,7 @@ int etnaviv_gpu_submit(struct etnaviv_gpu *gpu, hangcheck_timer_reset(gpu); ret = 0; +out_unlock: mutex_unlock(&gpu->lock); out_pm_put: