From: Ben Hutchings <ben@decadent.org.uk>
Date: Sun, 20 Jul 2014 23:06:48 +0000 (+0100)
Subject: dns_resolver: Null-terminate the right string
X-Git-Tag: v4.13~7006^2~2
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=640d7efe4c08f06c4ae5d31b79bd8740e7f6790a;p=mirror_ubuntu-bionic-kernel.git

dns_resolver: Null-terminate the right string

*_result[len] is parsed as *(_result[len]) which is not at all what we
want to touch here.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Fixes: 84a7c0b1db1c ("dns_resolver: assure that dns_query() result is null-terminated")
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c
index 9acec61f5433..dd8696a3dbec 100644
--- a/net/dns_resolver/dns_query.c
+++ b/net/dns_resolver/dns_query.c
@@ -150,7 +150,7 @@ int dns_query(const char *type, const char *name, size_t namelen,
 		goto put;
 
 	memcpy(*_result, upayload->data, len);
-	*_result[len] = '\0';
+	(*_result)[len] = '\0';
 
 	if (_expiry)
 		*_expiry = rkey->expiry;