From: Antoine Tenart Date: Tue, 13 Feb 2018 08:26:53 +0000 (+0100) Subject: crypto: inside-secure - fix the cache_len computation X-Git-Tag: Ubuntu-5.2.0-15.16~4696^2~168 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=666a9c70b04fccabde5cea5e680ae1ae92460a62;p=mirror_ubuntu-eoan-kernel.git crypto: inside-secure - fix the cache_len computation This patch fixes the cache length computation as cache_len could end up being a negative value. The check between the queued size and the block size is updated to reflect the caching mechanism which can cache up to a full block size (included!). Fixes: 809778e02cd4 ("crypto: inside-secure - fix hash when length is a multiple of a block") Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/inside-secure/safexcel_hash.c b/drivers/crypto/inside-secure/safexcel_hash.c index 8fac23b78da5..2951101e1831 100644 --- a/drivers/crypto/inside-secure/safexcel_hash.c +++ b/drivers/crypto/inside-secure/safexcel_hash.c @@ -184,7 +184,7 @@ static int safexcel_ahash_send_req(struct crypto_async_request *async, int ring, int i, queued, len, cache_len, extra, n_cdesc = 0, ret = 0; queued = len = req->len - req->processed; - if (queued < crypto_ahash_blocksize(ahash)) + if (queued <= crypto_ahash_blocksize(ahash)) cache_len = queued; else cache_len = queued - areq->nbytes;