From: Dominik Csapak <d.csapak@proxmox.com>
Date: Thu, 19 Oct 2017 12:36:19 +0000 (+0200)
Subject: make ldap paging working again
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=67390b83019856786e9e522f8724825823aa95c4;p=pmg-api.git

make ldap paging working again

the cookie can be defined but 0, so we need to check it like this
(the code is taken from the documentation of Net::LDAP::Control::Paged)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---

diff --git a/PMG/LDAPCache.pm b/PMG/LDAPCache.pm
index f45d61b..9d65010 100755
--- a/PMG/LDAPCache.pm
+++ b/PMG/LDAPCache.pm
@@ -239,14 +239,16 @@ sub queryusers {
 
 	# Get cookie from paged control
 	my ($resp) = $mesg->control(LDAP_CONTROL_PAGED) or last;
-	$cookie = $resp->cookie or last;
+	$cookie = $resp->cookie;
+
+	last if (!defined($cookie) || !length($cookie));
 
 	# Set cookie in paged control
 	$page->cookie($cookie);
     }
 
 
-    if ($cookie) {
+    if (defined($cookie) && length($cookie)) {
 	# We had an abnormal exit, so let the server know we do not want any more
 	$page->cookie($cookie);
 	$page->size(0);