From: Liu Jian Date: Mon, 20 Jul 2020 14:28:29 +0000 (+0800) Subject: dpaa_eth: Fix one possible memleak in dpaa_eth_probe X-Git-Tag: Ubuntu-5.13.0-19.19~5509^2~40 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=6790711f8ac5faabc43237c0d05d93db431a1ecc;p=mirror_ubuntu-jammy-kernel.git dpaa_eth: Fix one possible memleak in dpaa_eth_probe When dma_coerce_mask_and_coherent() fails, the alloced netdev need to be freed. Fixes: 060ad66f9795 ("dpaa_eth: change DMA device") Signed-off-by: Liu Jian Acked-by: Madalin Bucur Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 2972244e6eb0..43570f4911ea 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2938,7 +2938,7 @@ static int dpaa_eth_probe(struct platform_device *pdev) DMA_BIT_MASK(40)); if (err) { netdev_err(net_dev, "dma_coerce_mask_and_coherent() failed\n"); - return err; + goto free_netdev; } /* If fsl_fm_max_frm is set to a higher value than the all-common 1500,