From: Jiri Benc Date: Wed, 3 May 2017 02:20:03 +0000 (-0700) Subject: datapath: backport: vxlan: do not output confusing error message X-Git-Tag: v2.12.3~3401 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=69ee22a47a64984ed0b964574f75634234af3744;p=mirror_ovs.git datapath: backport: vxlan: do not output confusing error message Upstream commit: commit baf4d7860771287f30fbe9b6b2dc18b04361439d Author: Jiri Benc Date: Thu Apr 27 21:24:36 2017 +0200 vxlan: do not output confusing error message The message "Cannot bind port X, err=Y" creates only confusion. In metadata based mode, failure of IPv6 socket creation is okay if IPv6 is disabled and no error message should be printed. But when IPv6 tunnel was requested, such failure is fatal. The vxlan_socket_create does not know when the error is harmless and when it's not. Instead of passing such information down to vxlan_socket_create, remove the message completely. It's not useful. We propagate the error code up to the user space and the port number comes from the user space. There's nothing in the message that the process creating vxlan interface does not know. Signed-off-by: Jiri Benc Signed-off-by: David S. Miller Signed-off-by: Pravin B Shelar Acked-by: Joe Stringer --- diff --git a/datapath/linux/compat/vxlan.c b/datapath/linux/compat/vxlan.c index 50126ec7e..d27a5e293 100644 --- a/datapath/linux/compat/vxlan.c +++ b/datapath/linux/compat/vxlan.c @@ -1740,8 +1740,6 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, bool ipv6, sock = vxlan_create_sock(net, ipv6, port, flags); if (IS_ERR(sock)) { - pr_info("Cannot bind port %d, err=%ld\n", ntohs(port), - PTR_ERR(sock)); kfree(vs); return ERR_CAST(sock); }