From: Luiz Capitulino <lcapitulino@redhat.com>
Date: Tue, 8 Jan 2013 21:26:25 +0000 (-0200)
Subject: qemu-ga: ga_open_pidfile(): use qemu_open()
X-Git-Tag: v1.4.0-rc0~184^2~7
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=6ffacc5d3ddf2e3227aae2a8cc5c15627265f727;p=qemu.git

qemu-ga: ga_open_pidfile(): use qemu_open()

This ensures that O_CLOEXEC is passed to open(), this way the
pid file fd is not leaked to executed processes.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Amos Kong <akong@redhat.com>
Tested-by: Amos Kong <akong@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---

diff --git a/qga/main.c b/qga/main.c
index a9b968c50..4239150d4 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -267,7 +267,7 @@ static bool ga_open_pidfile(const char *pidfile)
     int pidfd;
     char pidstr[32];
 
-    pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
+    pidfd = qemu_open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
     if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) {
         g_critical("Cannot lock pid file, %s", strerror(errno));
         if (pidfd != -1) {