From: Eryu Guan Date: Sun, 21 Feb 2016 23:38:44 +0000 (-0500) Subject: ext4: iterate over buffer heads correctly in move_extent_per_page() X-Git-Tag: Ubuntu-5.10.0-12.13~13103^2 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=6ffe77bad545f4a7c8edd2a4ee797ccfcd894ab4;p=mirror_ubuntu-hirsute-kernel.git ext4: iterate over buffer heads correctly in move_extent_per_page() In commit bcff24887d00 ("ext4: don't read blocks from disk after extents being swapped") bh is not updated correctly in the for loop and wrong data has been written to disk. generic/324 catches this on sub-page block size ext4. Fixes: bcff24887d00 ("ext4: don't read blocks from disk after extentsbeing swapped") Signed-off-by: Eryu Guan Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index e032a0423e35..4098acc701c3 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -390,6 +390,7 @@ data_copy: *err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0); if (*err < 0) break; + bh = bh->b_this_page; } if (!*err) *err = block_commit_write(pagep[0], from, from + replaced_size);