From: Richard Yao <richard.yao@alumni.stonybrook.edu>
Date: Mon, 17 Oct 2022 06:18:09 +0000 (-0400)
Subject: Cleanup: zvol_add_clones() should not NULL check dp
X-Git-Tag: zfs-2.2.0~684
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=717641ac09315ef254a234f4b866e92662a691a1;p=mirror_zfs.git

Cleanup: zvol_add_clones() should not NULL check dp

It is never NULL because we return early if dsl_pool_hold() fails.

This caused Coverity to complain.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14042
---

diff --git a/module/zfs/zvol.c b/module/zfs/zvol.c
index 2e2860ff0..be8ee34f2 100644
--- a/module/zfs/zvol.c
+++ b/module/zfs/zvol.c
@@ -1026,8 +1026,7 @@ zvol_add_clones(const char *dsname, list_t *minors_list)
 out:
 	if (dd != NULL)
 		dsl_dir_rele(dd, FTAG);
-	if (dp != NULL)
-		dsl_pool_rele(dp, FTAG);
+	dsl_pool_rele(dp, FTAG);
 }
 
 /*