From: Peter Maydell Date: Sat, 17 Sep 2011 18:51:48 +0000 (+0100) Subject: hw/omap_gpmc: Add comment about FIFOTHRESHOLDSTATUS bit X-Git-Tag: v1.0-rc0~204 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=7196345549474719eb85c675174ce3717adf771b;p=qemu.git hw/omap_gpmc: Add comment about FIFOTHRESHOLDSTATUS bit Promote the remark about why we handle FIFOTHRESHOLDSTATUS the way we do from the commit message of de8af7fe0 to a comment in the code. Signed-off-by: Peter Maydell Signed-off-by: Andrzej Zaborowski --- diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c index 02f0c5210..e27b93c9b 100644 --- a/hw/omap_gpmc.c +++ b/hw/omap_gpmc.c @@ -569,6 +569,13 @@ static uint64_t omap_gpmc_read(void *opaque, target_phys_addr_t addr, case 0x1ec: /* GPMC_PREFETCH_CONTROL */ return s->prefetch.startengine; case 0x1f0: /* GPMC_PREFETCH_STATUS */ + /* NB: The OMAP3 TRM is inconsistent about whether the GPMC + * FIFOTHRESHOLDSTATUS bit should be set when + * FIFOPOINTER > FIFOTHRESHOLD or when it is >= FIFOTHRESHOLD. + * Apparently the underlying functional spec from which the TRM was + * created states that the behaviour is ">=", and this also + * makes more conceptual sense. + */ return (s->prefetch.fifopointer << 24) | ((s->prefetch.fifopointer >= ((s->prefetch.config1 >> 8) & 0x7f) ? 1 : 0) << 16) |