From: Casey Schaufler <casey@schaufler-ca.com>
Date: Mon, 28 Feb 2022 23:45:32 +0000 (-0800)
Subject: Fix incorrect type in assignment of ipv6 port for audit
X-Git-Tag: Ubuntu-5.4.0-117.132~212
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=73f7f2c366493759610c0952d78bd7ba95b949fa;p=mirror_ubuntu-focal-kernel.git

Fix incorrect type in assignment of ipv6 port for audit

BugLink: https://bugs.launchpad.net/bugs/1971497

[ Upstream commit a5cd1ab7ab679d252a6d2f483eee7d45ebf2040c ]

Remove inappropriate use of ntohs() and assign the
port value directly.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 182dd1b74ff6..86348173b41d 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -2494,7 +2494,7 @@ static int smk_ipv6_check(struct smack_known *subject,
 #ifdef CONFIG_AUDIT
 	smk_ad_init_net(&ad, __func__, LSM_AUDIT_DATA_NET, &net);
 	ad.a.u.net->family = PF_INET6;
-	ad.a.u.net->dport = ntohs(address->sin6_port);
+	ad.a.u.net->dport = address->sin6_port;
 	if (act == SMK_RECEIVING)
 		ad.a.u.net->v6info.saddr = address->sin6_addr;
 	else