From: Fiona Ebner <f.ebner@proxmox.com>
Date: Mon, 10 Jul 2023 08:53:02 +0000 (+0200)
Subject: qmeventd: VMID from PID: avoid goto
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=742da46a44f7d882620ae0d8d8cc08ab7b3f8dcc;hp=aaa77c9f7aa4419139a86f397abc4fce8a8e76dd;p=qemu-server.git

qmeventd: VMID from PID: avoid goto

If strtol() returns an errno, make sure not to print the error message
twice after the refactoring.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

diff --git a/qmeventd/qmeventd.c b/qmeventd/qmeventd.c
index 76a894c..002b2ac 100644
--- a/qmeventd/qmeventd.c
+++ b/qmeventd/qmeventd.c
@@ -134,20 +134,18 @@ get_vmid_from_pid(pid_t pid)
 	    continue;
 	}
 	if (errno != 0) {
-	    fprintf(stderr, "error parsing vmid for %d: %s\n", pid, strerror(errno));
 	    vmid = 0;
 	}
 
-	goto ret;
+	break;
     }
 
     if (errno) {
 	fprintf(stderr, "error parsing vmid for %d: %s\n", pid, strerror(errno));
-    } else {
+    } else if (!vmid) {
 	fprintf(stderr, "error parsing vmid for %d: no matching qemu.slice cgroup entry\n", pid);
     }
 
-ret:
     free(buf);
     fclose(fp);
     return vmid;