From: Li RongQing <lirongqing@baidu.com>
Date: Fri, 25 Jan 2019 11:08:33 +0000 (+0800)
Subject: flow: fix udp checksum
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=7a17a07d54d4f11a7e3ea1e7368cd5db92c3f21f;p=ovs.git

flow: fix udp checksum

As per RFC 768, if the calculated UDP checksum is 0, it should be
instead set as 0xFFFF in the frame. A value of 0 in the checksum
field indicates to the receiver that no checksum was calculated
and hence it should not verify the checksum.

Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
---

diff --git a/lib/flow.c b/lib/flow.c
index c60446ff4..c6e47781b 100644
--- a/lib/flow.c
+++ b/lib/flow.c
@@ -3023,6 +3023,9 @@ flow_compose_l4_csum(struct dp_packet *p, const struct flow *flow,
             udp->udp_csum = 0;
             udp->udp_csum = csum_finish(csum_continue(pseudo_hdr_csum,
                                                       udp, l4_len));
+            if (!udp->udp_csum) {
+                udp->udp_csum = htons(0xffff);
+            }
         } else if (flow->nw_proto == IPPROTO_ICMP) {
             struct icmp_header *icmp = dp_packet_l4(p);