From: Stephen Hemminger Date: Tue, 6 Dec 2011 20:09:56 +0000 (+0400) Subject: zebra: fix warnings in forward proc X-Git-Tag: frr-2.0-rc1~1918^2~18 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=7e7a2d38b2d5d5edd3be7d6754d67c3231ee215e;p=mirror_frr.git zebra: fix warnings in forward proc Check result of fgets(), and don't set variable that is never used. --- diff --git a/zebra/ipforward_proc.c b/zebra/ipforward_proc.c index 73846137a..2876eded3 100644 --- a/zebra/ipforward_proc.c +++ b/zebra/ipforward_proc.c @@ -45,7 +45,6 @@ ipforward (void) { FILE *fp; int ipforwarding = 0; - char *pnt; char buf[10]; fp = fopen (proc_net_snmp, "r"); @@ -59,8 +58,8 @@ ipforward (void) /* Get ip_statistics.IpForwarding : 1 => ip forwarding enabled 2 => ip forwarding off. */ - pnt = fgets (buf, 6, fp); - sscanf (buf, "Ip: %d", &ipforwarding); + if (fgets (buf, 6, fp)) + sscanf (buf, "Ip: %d", &ipforwarding); fclose(fp); @@ -140,8 +139,8 @@ ipforward_ipv6 (void) if (fp == NULL) return -1; - fgets (buf, 2, fp); - sscanf (buf, "%d", &ipforwarding); + if (fgets (buf, 2, fp)) + sscanf (buf, "%d", &ipforwarding); fclose (fp); return ipforwarding;