From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 27 Jun 2011 13:53:38 +0000 (+0200)
Subject: ALSA: hda - Fix volume-init for ALC259 with invalid widget caps
X-Git-Tag: Ubuntu-5.13.0-19.19~26756^2^2~65
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=7ec9c6ccc6007b14a916021d4ba7ffbcc7822ae3;p=mirror_ubuntu-jammy-kernel.git

ALSA: hda - Fix volume-init for ALC259 with invalid widget caps

ALC259 seems to provide an invalid widget capability for the input-src
selector widget.  The widget shows the input-amp while it's a selector,
and this confuses the current ALC882 initialization code that is used
for ALC259, too.  For fixing this, check the amp capability and handle
the connection selection individually.

Also, ALC259 has no mute bit in DAC volume, so we need to initialize
it as ZERO instead of MUTE.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 5293f7f7f425..0fefc656c6e0 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11075,6 +11075,7 @@ static void alc882_auto_init_input_src(struct hda_codec *codec)
 		unsigned int mux_idx;
 		const struct hda_input_mux *imux;
 		int conns, mute, idx, item;
+		unsigned int wid_type;
 
 		/* mute ADC */
 		snd_hda_codec_write(codec, spec->adc_nids[c], 0,
@@ -11088,6 +11089,7 @@ static void alc882_auto_init_input_src(struct hda_codec *codec)
 		imux = &spec->input_mux[mux_idx];
 		if (!imux->num_items && mux_idx > 0)
 			imux = &spec->input_mux[0];
+		wid_type = get_wcaps_type(get_wcaps(codec, nid));
 		for (idx = 0; idx < conns; idx++) {
 			/* if the current connection is the selected one,
 			 * unmute it as default - otherwise mute it
@@ -11100,17 +11102,13 @@ static void alc882_auto_init_input_src(struct hda_codec *codec)
 					break;
 				}
 			}
-			/* check if we have a selector or mixer
-			 * we could check for the widget type instead, but
-			 * just check for Amp-In presence (in case of mixer
-			 * without amp-in there is something wrong, this
-			 * function shouldn't be used or capsrc nid is wrong)
-			 */
-			if (get_wcaps(codec, nid) & AC_WCAP_IN_AMP)
+			/* initialize the mute status if mute-amp is present */
+			if (query_amp_caps(codec, nid, HDA_INPUT) & AC_AMPCAP_MUTE)
 				snd_hda_codec_write(codec, nid, 0,
 						    AC_VERB_SET_AMP_GAIN_MUTE,
 						    mute);
-			else if (mute != AMP_IN_MUTE(idx))
+			if (wid_type == AC_WID_AUD_SEL &&
+			    mute != AMP_IN_MUTE(idx))
 				snd_hda_codec_write(codec, nid, 0,
 						    AC_VERB_SET_CONNECT_SEL,
 						    idx);
@@ -13594,7 +13592,7 @@ static void alc268_auto_init_dac(struct hda_codec *codec, hda_nid_t nid)
 	if (!nid)
 		return;
 	snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_AMP_GAIN_MUTE,
-			    AMP_OUT_MUTE);
+			    AMP_OUT_ZERO);
 }
 
 static void alc268_auto_init_multi_out(struct hda_codec *codec)