From: Lubomir Rintel Date: Mon, 17 Sep 2018 12:11:24 +0000 (+0200) Subject: spi: pxa2xx: Remove the shutdown callback X-Git-Tag: Ubuntu-5.10.0-12.13~6543^2~55 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=8089babee17c09cdd51ac1390e444ee0be0c2291;p=mirror_ubuntu-hirsute-kernel.git spi: pxa2xx: Remove the shutdown callback It makes no sense to remove the device on shutdown. And it break things when the hardware crucial for shutdown (such as the embedded controller) is attached to the SPI bus. Signed-off-by: Lubomir Rintel Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index e3cbc66a7061..fc9aac214239 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1764,14 +1764,6 @@ static int pxa2xx_spi_remove(struct platform_device *pdev) return 0; } -static void pxa2xx_spi_shutdown(struct platform_device *pdev) -{ - int status = 0; - - if ((status = pxa2xx_spi_remove(pdev)) != 0) - dev_err(&pdev->dev, "shutdown failed with %d\n", status); -} - #ifdef CONFIG_PM_SLEEP static int pxa2xx_spi_suspend(struct device *dev) { @@ -1845,7 +1837,6 @@ static struct platform_driver driver = { }, .probe = pxa2xx_spi_probe, .remove = pxa2xx_spi_remove, - .shutdown = pxa2xx_spi_shutdown, }; static int __init pxa2xx_spi_init(void)