From: Miaoqian Lin Date: Mon, 7 Mar 2022 11:51:16 +0000 (+0000) Subject: pinctrl: nomadik: Add missing of_node_put() in nmk_pinctrl_probe X-Git-Tag: Ubuntu-5.4.0-117.132~238 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=81f18dac8c181cb68c9fe6f6b6bbcd5f937be085;p=mirror_ubuntu-focal-kernel.git pinctrl: nomadik: Add missing of_node_put() in nmk_pinctrl_probe BugLink: https://bugs.launchpad.net/bugs/1971497 [ Upstream commit c09ac191b1f97cfa06f394dbfd7a5db07986cefc ] This node pointer is returned by of_parse_phandle() with refcount incremented in this function. Calling of_node_put() to avoid the refcount leak. Fixes: 32e67eee670e ("pinctrl: nomadik: Allow prcm_base to be extracted from Device Tree") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220307115116.25316-1-linmq006@gmail.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin Signed-off-by: Kamal Mostafa Signed-off-by: Stefan Bader --- diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index 2a8190b11d10..9f00adfefba8 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -1923,8 +1923,10 @@ static int nmk_pinctrl_probe(struct platform_device *pdev) } prcm_np = of_parse_phandle(np, "prcm", 0); - if (prcm_np) + if (prcm_np) { npct->prcm_base = of_iomap(prcm_np, 0); + of_node_put(prcm_np); + } if (!npct->prcm_base) { if (version == PINCTRL_NMK_STN8815) { dev_info(&pdev->dev,