From: Philippe Mathieu-Daudé Date: Thu, 9 Jan 2020 00:05:23 +0000 (+0100) Subject: hw/hppa/machine: Correctly check the firmware is in PDC range X-Git-Tag: v5.0.0-rc3~162^2~3 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=8262863d4b59aed7e22866234dcfd3d8fb016a6b;p=mirror_qemu.git hw/hppa/machine: Correctly check the firmware is in PDC range The firmware has to reside in the PDC range. If the Elf file expects to load it below FIRMWARE_START, it is incorrect, regardless the RAM size. Acked-by: Helge Deller Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200109000525.24744-2-f4bug@amsat.org> Signed-off-by: Richard Henderson --- diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index a35527cfc7..e57530950a 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -171,7 +171,7 @@ static void machine_hppa_init(MachineState *machine) qemu_log_mask(CPU_LOG_PAGE, "Firmware loaded at 0x%08" PRIx64 "-0x%08" PRIx64 ", entry at 0x%08" PRIx64 ".\n", firmware_low, firmware_high, firmware_entry); - if (firmware_low < ram_size || firmware_high >= FIRMWARE_END) { + if (firmware_low < FIRMWARE_START || firmware_high >= FIRMWARE_END) { error_report("Firmware overlaps with memory or IO space"); exit(1); }