From: Srinivas Kandagatla Date: Thu, 28 Mar 2019 16:22:18 +0000 (+0000) Subject: regmap: regmap-irq: fix getting type default values X-Git-Tag: Ubuntu-5.2.0-15.16~2043^2~1^2 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=8293488205f145aeefbec76f231303c8e32647a2;p=mirror_ubuntu-eoan-kernel.git regmap: regmap-irq: fix getting type default values Checking for value of type default value just after allocating will always be zero and the type register default values will never be read, so fix this! Without this patch setting irq type will be silently ignored. Patch "regmap: regmap-irq: Remove default irq type setting from core" did remove the default mask but it forgot to remove the check before reading the default type register. Fixes: 84267d1b18ab ("regmap: regmap-irq: Remove default irq type setting from core") Signed-off-by: Srinivas Kandagatla Signed-off-by: Mark Brown --- diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c index 1bd1145ad8b5..b476918c5e50 100644 --- a/drivers/base/regmap/regmap-irq.c +++ b/drivers/base/regmap/regmap-irq.c @@ -664,9 +664,6 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags, if (chip->num_type_reg && !chip->type_in_mask) { for (i = 0; i < chip->num_type_reg; ++i) { - if (!d->type_buf_def[i]) - continue; - reg = chip->type_base + (i * map->reg_stride * d->type_reg_stride);