From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Mon, 19 Feb 2024 16:36:02 +0000 (+0100)
Subject: ui: storage: enable download-url button with Sys.AccessNetwork capability
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=846defd88cc2ea22d8e25e38135f653c4c98beb4;hp=6cf1a48d45417aa8a698f9dadb48a6fe4a206029;p=pve-manager.git

ui: storage: enable download-url button with Sys.AccessNetwork capability

Now that the new Sys.AccessNetwork privilege got added to
access-control and the storage download and manager query API
endpoints, the UI should reflect that change and allow opening the
dialogue to download an image from URL also for the users that are
allowed to do so through the new privilege.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Hannes Duerr <h.duerr@proxmox.com>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---

diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js
index 457816a6..c2ad01e9 100644
--- a/www/manager6/storage/Browser.js
+++ b/www/manager6/storage/Browser.js
@@ -51,7 +51,10 @@ Ext.define('PVE.storage.Browser', {
 	    let contents = res.content.split(',');
 
 	    let enableUpload = !!caps.storage['Datastore.AllocateTemplate'];
-	    let enableDownloadUrl = enableUpload && !!(caps.nodes['Sys.Audit'] && caps.nodes['Sys.Modify']);
+	    let enableDownloadUrl = enableUpload && (
+		!!(caps.nodes['Sys.Audit'] && caps.nodes['Sys.Modify']) || // for backward compat
+		!!caps.nodes['Sys.AccessNetwork'] // new explicit priv for querying (local) networks
+	    );
 
 	    if (contents.includes('backup')) {
 		me.items.push({