From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Thu, 16 Nov 2017 04:27:18 +0000 (+0530)
Subject: isdn: hisax: Fix pnp_irq's error checking for setup_asuscom
X-Git-Tag: Ubuntu-5.2.0-15.16~5517^2~13^2~11
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=84dcc16c52baa3a75860bc26a16a4b5d96bb6936;p=mirror_ubuntu-eoan-kernel.git

isdn: hisax: Fix pnp_irq's error checking for setup_asuscom

The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/isdn/hisax/asuscom.c b/drivers/isdn/hisax/asuscom.c
index 62f9c43e2377..74c871495e81 100644
--- a/drivers/isdn/hisax/asuscom.c
+++ b/drivers/isdn/hisax/asuscom.c
@@ -348,7 +348,7 @@ int setup_asuscom(struct IsdnCard *card)
 					}
 					card->para[1] = pnp_port_start(pnp_d, 0);
 					card->para[0] = pnp_irq(pnp_d, 0);
-					if (!card->para[0] || !card->para[1]) {
+					if (card->para[0] == -1 || !card->para[1]) {
 						printk(KERN_ERR "AsusPnP:some resources are missing %ld/%lx\n",
 						       card->para[0], card->para[1]);
 						pnp_disable_dev(pnp_d);