From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Wed, 5 May 2021 21:06:43 +0000 (+0200)
Subject: netfilter: nftables: Fix a memleak from userdata error path in new objects
X-Git-Tag: v5.15~1156^2^2~2
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=85dfd816fabfc16e71786eda0a33a7046688b5b0;p=mirror_ubuntu-kernels.git

netfilter: nftables: Fix a memleak from userdata error path in new objects

Release object name if userdata allocation fails.

Fixes: b131c96496b3 ("netfilter: nf_tables: add userdata support for nft_object")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index 0b7fe0a902ff..926da6ed8d51 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -6615,9 +6615,9 @@ err_obj_ht:
 	INIT_LIST_HEAD(&obj->list);
 	return err;
 err_trans:
-	kfree(obj->key.name);
-err_userdata:
 	kfree(obj->udata);
+err_userdata:
+	kfree(obj->key.name);
 err_strdup:
 	if (obj->ops->destroy)
 		obj->ops->destroy(&ctx, obj);