From: Dan Carpenter Date: Tue, 31 May 2022 12:10:05 +0000 (+0300) Subject: net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6() X-Git-Tag: v5.19~364^2~13 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=86360030cc5117596626bef1d937277cd2bebe05;p=mirror_ubuntu-kernels.git net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6() The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return false on failure. It should not return negatives because that means succes/true. Fixes: fcb6aa86532c ("act_ct: Support GRE offload") Signed-off-by: Dan Carpenter Acked-by: Toshiaki Makita Link: https://lore.kernel.org/r/YpYFnbDxFl6tQ3Bn@kili Signed-off-by: Paolo Abeni --- diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c index 8af9d6e5ba61..e013253b10d1 100644 --- a/net/sched/act_ct.c +++ b/net/sched/act_ct.c @@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb, break; #endif default: - return -1; + return false; } if (ip6h->hop_limit <= 1)