From: Kumar Gala Date: Fri, 29 Jun 2007 05:12:04 +0000 (-0500) Subject: gianfar: Fix typo bug introduced by move to udp_hdr() X-Git-Tag: Ubuntu-5.0.0-8.9~41818^2~12^2 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=8da32de5c845b711a500f89342baf10c662e2ecb;p=mirror_ubuntu-disco-kernel.git gianfar: Fix typo bug introduced by move to udp_hdr() In commit 4bedb45203eab92a87b4c863fe2d0cded633427f both the udp and tcp cases where changed to use udp_hdr() instead of leaving the tcp case alone and fixing with tcp_hdr(). This ended up causing random behavior with TCP connections because of looking for tcp_hdr()->check in the wrong place. Signed-off-by: Kumar Gala --- diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 6822bf14267b..1b854bf07b09 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -944,7 +944,7 @@ static inline void gfar_tx_checksum(struct sk_buff *skb, struct txfcb *fcb) flags |= TXFCB_UDP; fcb->phcs = udp_hdr(skb)->check; } else - fcb->phcs = udp_hdr(skb)->check; + fcb->phcs = tcp_hdr(skb)->check; /* l3os is the distance between the start of the * frame (skb->data) and the start of the IP hdr.