From: Colin Ian King <colin.king@canonical.com>
Date: Wed, 7 Sep 2016 16:23:09 +0000 (+0100)
Subject: staging: ks7010: avoid dereferencing packet if it is null
X-Git-Tag: Ubuntu-5.13.0-19.19~14927^2~742
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=8defffb20854500825162d336bdd183d2d218cf9;p=mirror_ubuntu-jammy-kernel.git

staging: ks7010: avoid dereferencing packet if it is null

Updating tx_bytes from packet->len if packet is null will cause
a null pointer dereference, so only update tx_bytes if it packet
is not null.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index 1e21eb1c4667..d69b4c945d21 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -3396,13 +3396,13 @@ void send_packet_complete(void *arg1, void *arg2)
 
 	DPRINTK(3, "\n");
 
-	priv->nstats.tx_bytes += packet->len;
 	priv->nstats.tx_packets++;
 
 	if (netif_queue_stopped(priv->net_dev))
 		netif_wake_queue(priv->net_dev);
 
 	if (packet) {
+		priv->nstats.tx_bytes += packet->len;
 		dev_kfree_skb(packet);
 		packet = NULL;
 	}