From: Stephan Mueller <smueller@chronox.de>
Date: Fri, 17 Apr 2015 12:54:08 +0000 (+0200)
Subject: cryoto: drbg - clear all temporary memory
X-Git-Tag: Ubuntu-snapdragon-4.4.0-1029.32~6444^2~291
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=8e0498d99f182dd06c012dfc62768e8ca0450adf;p=mirror_ubuntu-zesty-kernel.git

cryoto: drbg - clear all temporary memory

The buffer uses for temporary data must be cleared entirely. In AES192
the used buffer is drbg_statelen(drbg) + drbg_blocklen(drbg) as
documented in the comment above drbg_ctr_df.

This patch ensures that the temp buffer is completely wiped.

Signed-off-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/crypto/drbg.c b/crypto/drbg.c
index b69409cb7e6a..8d2944fab8e8 100644
--- a/crypto/drbg.c
+++ b/crypto/drbg.c
@@ -487,7 +487,7 @@ static int drbg_ctr_df(struct drbg_state *drbg,
 
 out:
 	memset(iv, 0, drbg_blocklen(drbg));
-	memset(temp, 0, drbg_statelen(drbg));
+	memset(temp, 0, drbg_statelen(drbg) + drbg_blocklen(drbg));
 	memset(pad, 0, drbg_blocklen(drbg));
 	return ret;
 }