From: Jiri Pirko <jiri@mellanox.com>
Date: Thu, 28 Dec 2017 15:52:10 +0000 (+0100)
Subject: net: sched: don't set extack message in case the qdisc will be created
X-Git-Tag: Ubuntu-5.13.0-19.19~11697^2~274
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=8ec69574031bb8e0a19cf318c093acc871abd965;p=mirror_ubuntu-jammy-kernel.git

net: sched: don't set extack message in case the qdisc will be created

If the qdisc is not found here, it is going to be created. Therefore,
this is not an error path. Remove the extack message set and don't
confuse user with error message in case the qdisc was created
successfully.

Fixes: 09215598119e ("net: sched: sch_api: handle generic qdisc errors")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 3a3a1da6b071..81ecf5bec26d 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -1402,10 +1402,8 @@ replay:
 					return -EINVAL;
 				}
 				q = qdisc_lookup(dev, tcm->tcm_handle);
-				if (!q) {
-					NL_SET_ERR_MSG(extack, "No qdisc found for specified handle");
+				if (!q)
 					goto create_n_graft;
-				}
 				if (n->nlmsg_flags & NLM_F_EXCL) {
 					NL_SET_ERR_MSG(extack, "Exclusivity flag on, cannot override");
 					return -EEXIST;