From: Philipp Reisner Date: Mon, 10 May 2010 14:03:10 +0000 (+0200) Subject: drbd: Removed redundant error checks in the request code path X-Git-Tag: Ubuntu-5.0.0-8.9~21319^2~70 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=905cd7d8ac9b18e1f122b90dbebe1246b1c364fd;p=mirror_ubuntu-disco-kernel.git drbd: Removed redundant error checks in the request code path Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index 39c2cc3614e4..48647589aa0d 100644 --- a/drivers/block/drbd/drbd_req.c +++ b/drivers/block/drbd/drbd_req.c @@ -984,21 +984,6 @@ static int drbd_fail_request_early(struct drbd_conf *mdev, int is_write) return 1; } - /* - * Paranoia: we might have been primary, but sync target, or - * even diskless, then lost the connection. - * This should have been handled (panic? suspend?) somewhere - * else. But maybe it was not, so check again here. - * Caution: as long as we do not have a read/write lock on mdev, - * to serialize state changes, this is racy, since we may lose - * the connection *after* we test for the cstate. - */ - if (mdev->state.disk < D_UP_TO_DATE && mdev->state.pdsk < D_UP_TO_DATE) { - if (__ratelimit(&drbd_ratelimit_state)) - dev_err(DEV, "Sorry, I have no access to good data anymore.\n"); - return 1; - } - return 0; }