From: Eric Garver <e@erig.me>
Date: Thu, 16 Mar 2017 14:22:32 +0000 (-0400)
Subject: checkpatch.py: Fix false positive on if/when/for
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=973496b9be6265e59d89d00fecc94b28e6e72816;p=ovs.git

checkpatch.py: Fix false positive on if/when/for

We need to use == instead of the is operator. If you're unlucky it may
fail because they're not exactly the same object, but hold the same
value.

Example false positive:

E(120): Inappropriate bracing around statement

+            if (0 != nl_attr_get_u8(vxlan[IFLA_VXLAN_LEARNING])

Fixes: 30c7ffd5ac46 ("utilities/checkpatch.py: Check for appropriate bracing")
Signed-off-by: Eric Garver <e@erig.me>
Signed-off-by: Russell Bryant <russell@ovn.org>
---

diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index dfe6f9c76..638ac9774 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -144,11 +144,11 @@ def if_and_for_end_with_bracket_check(line):
         """This is a rather naive counter - it won't deal with quotes"""
         balance = 0
         for letter in line:
-            if letter is '(':
+            if letter == '(':
                 balance += 1
-            elif letter is ')':
+            elif letter == ')':
                 balance -= 1
-        return balance is 0
+        return balance == 0
 
     if __regex_is_for_if_single_line_bracket.search(line) is not None:
         if not balanced_parens(line):