From: Dan Carpenter Date: Tue, 15 Mar 2016 07:18:49 +0000 (+0300) Subject: mediatek: checking for IS_ERR() instead of NULL X-Git-Tag: Ubuntu-4.8.0-22.24~1652^2~20 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=977bc20cf66367a530d17696f7e1783510a115b7;p=mirror_ubuntu-zesty-kernel.git mediatek: checking for IS_ERR() instead of NULL of_phy_connect() returns NULL on error, it never returns error pointers. Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet') Signed-off-by: Dan Carpenter Acked-by: John Crispin Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 1e6c5498bba9..fd19d2d163b8 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac, phydev = of_phy_connect(eth->netdev[mac->id], phy_node, mtk_phy_link_adjust, 0, phy_mode); - if (IS_ERR(phydev)) { + if (!phydev) { dev_err(eth->dev, "could not connect to PHY\n"); - return PTR_ERR(phydev); + return -ENODEV; } dev_info(eth->dev,